[MRG] deadlock between async dispatch and exception handling #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes it works. @lesteve merge? |
|
LGTM. just curious, are you sure that removing the lock won't introduce other problems ? |
That was the discussion we were having but it looks like @ogrisel is confident the lock wasn't necessary. Let's merge this one then, thanks ! |
lesteve
added a commit
that referenced
this pull request
Jan 13, 2016
[MRG] deadlock between async dispatch and exception handling
I don't understand why I decided to use the lock there in the first place: we destroy the pool instance and therefore stop all its thread without waiting for them to complete. |
ogrisel
added a commit
that referenced
this pull request
Jan 18, 2016
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Sep 30, 2016
* tag '0.9.4': (46 commits) Release 0.9.4 DOC add missing changelog entry for joblib#296 DOC add entry to changelog for joblib#294 ENH spare one file descriptor / syscall in automemmap FIX auto-memmap gc bug by always hashing arrays TST non-regression test for auto-memmap / gc bug Add link to github issues for 0.9.4 changelog entries Fix my_exceptions._mk_exception when input exception is not inheritable add entry in changelog fixing hashing with mixed dtype + test Use _compat.PY3_OR_LATER where possible COSMIT fix some PEP8 horizontal misalignments Move definition of PY3_OR_LATER to _compat.py Do not use inspect.getargspec FIX joblib#295: deadlock between async dispatch and exception handling Add section in CHANGES.rst TRAVIS use numpy 1.10 FIX style and pyflakes in test_pool.py Fix Parallel hanging with exhausted iterator remove useless section about versions of python prior to 2.6 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a deadlock identified in #295.